-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADD demo images to a new img folder with the documentation site #2644
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but something is wrong with the docs build
I need to do a few more things, I'll merge it when I'm ready |
1515dc5
to
bac24be
Compare
Merge when ready |
Codecov Report
@@ Coverage Diff @@
## master #2644 +/- ##
=======================================
Coverage 34.34% 34.34%
=======================================
Files 389 389
Lines 8750 8750
Branches 914 918 +4
=======================================
Hits 3005 3005
- Misses 5122 5134 +12
+ Partials 623 611 -12
Continue to review full report at Codecov.
|
ADD demo images to a new img folder with the documentation site
Fixes: #2642
What I did
Add demo images to the documentation site, so we can reference them from anywhere (not just github) (good for npm readme page etc)