Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD demo images to a new img folder with the documentation site #2644

Merged
merged 3 commits into from
Jan 4, 2018

Conversation

ndelangen
Copy link
Member

Fixes: #2642

What I did

Add demo images to the documentation site, so we can reference them from anywhere (not just github) (good for npm readme page etc)

Copy link
Member

@igor-dv igor-dv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but something is wrong with the docs build

@ndelangen
Copy link
Member Author

I need to do a few more things, I'll merge it when I'm ready

@storybookjs storybookjs deleted a comment from codecov bot Jan 4, 2018
@ndelangen ndelangen force-pushed the fix/add-demoimgs-to-docs branch from 1515dc5 to bac24be Compare January 4, 2018 15:32
@storybookjs storybookjs deleted a comment from codecov bot Jan 4, 2018
@storybookjs storybookjs deleted a comment from codecov bot Jan 4, 2018
@ndelangen
Copy link
Member Author

Merge when ready

@storybookjs storybookjs deleted a comment from codecov bot Jan 4, 2018
@codecov
Copy link

codecov bot commented Jan 4, 2018

Codecov Report

Merging #2644 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2644   +/-   ##
=======================================
  Coverage   34.34%   34.34%           
=======================================
  Files         389      389           
  Lines        8750     8750           
  Branches      914      918    +4     
=======================================
  Hits         3005     3005           
- Misses       5122     5134   +12     
+ Partials      623      611   -12
Impacted Files Coverage Δ
app/vue/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/react/src/server/utils.js 0% <0%> (-53.58%) ⬇️
addons/a11y/src/components/Tabs.js 0% <0%> (ø) ⬆️
addons/viewport/src/components/viewportInfo.js 36.36% <0%> (ø) ⬆️
lib/codemod/src/transforms/move-buildin-addons.js 46.87% <0%> (ø) ⬆️
...react-native/src/manager/components/PreviewHelp.js 0% <0%> (ø) ⬆️
lib/core/src/client/preview/story_store.js 52.88% <0%> (ø) ⬆️
...es__/update-addon-info/update-addon-info.output.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/addon_panel.js 23.52% <0%> (ø) ⬆️
...tive/src/preview/components/StoryListView/index.js 0% <0%> (ø) ⬆️
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ece503a...37e2a8b. Read the comment docs.

@ndelangen ndelangen merged commit 3d27358 into master Jan 4, 2018
@ndelangen ndelangen deleted the fix/add-demoimgs-to-docs branch January 4, 2018 16:20
Hypnosphi pushed a commit that referenced this pull request Feb 12, 2018
ADD demo images to a new img folder with the documentation site
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants