Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the timezone for example dates #2654

Merged
merged 1 commit into from
Jan 5, 2018
Merged

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Jan 5, 2018

Issue: Unit tests were failing in Australia

(20 Jan in Australia is 19th Jan in "en-US". I know this! It is my birthday, and I have colleagues in the US!!)

What I did

Ensure a consistent created date that doesn't depend on local TZ.

@tmeasday tmeasday requested a review from a team January 5, 2018 01:16
@Hypnosphi Hypnosphi added the maintenance User-facing maintenance tasks label Jan 5, 2018
@codecov
Copy link

codecov bot commented Jan 5, 2018

Codecov Report

Merging #2654 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2654   +/-   ##
=======================================
  Coverage   34.34%   34.34%           
=======================================
  Files         389      389           
  Lines        8750     8750           
  Branches      902      902           
=======================================
  Hits         3005     3005           
- Misses       5129     5159   +30     
+ Partials      616      586   -30
Impacted Files Coverage Δ
addons/knobs/src/angular/utils.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/components/layout/usplit.js 38.7% <0%> (ø) ⬆️
...modules/ui/components/stories_panel/text_filter.js 30.98% <0%> (ø) ⬆️
addons/actions/src/lib/decycle.js 53.52% <0%> (ø) ⬆️
addons/knobs/src/components/types/Number.js 7.93% <0%> (ø) ⬆️
lib/ui/src/modules/ui/components/layout/index.js 29.28% <0%> (ø) ⬆️
app/react/src/client/preview/element_check.js 67.64% <0%> (ø) ⬆️
...-native/src/preview/components/OnDeviceUI/style.js 0% <0%> (ø) ⬆️
addons/a11y/src/components/Report/Elements.js 0% <0%> (ø) ⬆️
addons/actions/src/lib/util/typeReviver.js 71.42% <0%> (ø) ⬆️
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35d2636...8c5f470. Read the comment docs.

@Hypnosphi Hypnosphi merged commit 9d2c34c into master Jan 5, 2018
@Hypnosphi Hypnosphi deleted the tmeasday/fix-knobs-dates branch January 5, 2018 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants