Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix config dir detection #2666

Merged
merged 2 commits into from
Jan 6, 2018
Merged

Fix config dir detection #2666

merged 2 commits into from
Jan 6, 2018

Conversation

Hypnosphi
Copy link
Member

Issue: #2665

The problem is that getConfigDir don't read from CLI arguments.

How to test

Since this PR, here's how official-storybook looks like if both of the *-head.html aren't loaded:
screen shot 2018-01-06 at 22 45 27

@Hypnosphi Hypnosphi merged commit 7e3b29c into master Jan 6, 2018
@Hypnosphi Hypnosphi deleted the fix-config-dir-detection branch January 6, 2018 22:44
@Hypnosphi Hypnosphi added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jan 6, 2018
@@ -0,0 +1,10 @@
import { document } from 'global';

export default function addHeadWarning(bundle) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's nice one 👍

shilman pushed a commit that referenced this pull request Jan 7, 2018
shilman pushed a commit that referenced this pull request Jan 7, 2018
@Hypnosphi Hypnosphi added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
angular bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch react vue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants