Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only update CLI snapsots on postpublish script, skip smoke tests #2671

Merged
merged 2 commits into from
Jan 7, 2018

Conversation

Hypnosphi
Copy link
Member

This is a follow-up to #2565

Smoke tests are too long to run, but there's no actual need to do them after publishing (they will run on CI anyway).

Labelling it with patch as it affects publishing process

@Hypnosphi Hypnosphi added maintenance User-facing maintenance tasks patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jan 7, 2018
@Hypnosphi Hypnosphi requested a review from shilman January 7, 2018 13:43
@codecov
Copy link

codecov bot commented Jan 7, 2018

Codecov Report

Merging #2671 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2671   +/-   ##
=======================================
  Coverage   34.35%   34.35%           
=======================================
  Files         389      389           
  Lines        8747     8747           
  Branches      903      904    +1     
=======================================
  Hits         3005     3005           
+ Misses       5139     5127   -12     
- Partials      603      615   +12
Impacted Files Coverage Δ
.../src/modules/ui/components/stories_panel/header.js 29.62% <0%> (ø) ⬆️
lib/codemod/src/transforms/move-buildin-addons.js 46.87% <0%> (ø) ⬆️
...tories_panel/stories_tree/tree_decorators_utils.js 45.23% <0%> (ø) ⬆️
addons/knobs/src/components/types/Number.js 7.93% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/routed_link.js 22.72% <0%> (ø) ⬆️
addons/info/src/components/types/Shape.js 68.62% <0%> (ø) ⬆️
lib/core/src/client/preview/story_store.js 52.88% <0%> (ø) ⬆️
addons/actions/src/lib/decycle.js 53.52% <0%> (ø) ⬆️
app/react-native/src/bin/storybook.js 0% <0%> (ø) ⬆️
addons/a11y/src/components/Report/Item.js 0% <0%> (ø) ⬆️
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71c528c...7cf307c. Read the comment docs.

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!!!

@shilman shilman merged commit e1baaf4 into master Jan 7, 2018
@shilman shilman deleted the cli-update-only branch January 7, 2018 14:37
shilman added a commit that referenced this pull request Jan 8, 2018
Only update CLI snapsots on postpublish script, skip smoke tests
@Hypnosphi Hypnosphi added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants