Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove src from indidivudal .npmignore files #2677

Merged
merged 1 commit into from
Jan 8, 2018
Merged

Remove src from indidivudal .npmignore files #2677

merged 1 commit into from
Jan 8, 2018

Conversation

hswolff
Copy link
Contributor

@hswolff hswolff commented Jan 8, 2018

Fixes #2602

cc @Hypnosphi

@codecov
Copy link

codecov bot commented Jan 8, 2018

Codecov Report

Merging #2677 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2677   +/-   ##
=======================================
  Coverage   34.35%   34.35%           
=======================================
  Files         389      389           
  Lines        8747     8747           
  Branches      904      910    +6     
=======================================
  Hits         3005     3005           
- Misses       5127     5136    +9     
+ Partials      615      606    -9
Impacted Files Coverage Δ
...tive/src/preview/components/StoryListView/index.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/components/search_box.js 36.36% <0%> (ø) ⬆️
lib/ui/src/modules/ui/components/shortcuts_help.js 12.85% <0%> (ø) ⬆️
...tories_panel/stories_tree/tree_decorators_utils.js 45.23% <0%> (ø) ⬆️
...react-native/src/manager/components/PreviewHelp.js 0% <0%> (ø) ⬆️
addons/info/src/components/PropVal.js 82.82% <0%> (ø) ⬆️
lib/codemod/src/transforms/move-buildin-addons.js 46.87% <0%> (ø) ⬆️
...ents/stories_panel/stories_tree/tree_decorators.js 34.37% <0%> (ø) ⬆️
lib/ui/src/modules/ui/components/layout/usplit.js 38.7% <0%> (ø) ⬆️
...dons/actions/src/lib/types/object/getObjectName.js 62.5% <0%> (ø) ⬆️
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f153e9...b34826d. Read the comment docs.

Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmeasday tmeasday merged commit b4d6af4 into storybookjs:master Jan 8, 2018
@hswolff hswolff deleted the remove-src-from-npmignore branch January 8, 2018 03:19
@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jan 8, 2018
shilman pushed a commit that referenced this pull request Jan 8, 2018
Remove src from indidivudal .npmignore files
tmeasday added a commit that referenced this pull request Jan 8, 2018
@ktj
Copy link
Contributor

ktj commented Jan 8, 2018

This fixes problems with storybook apps, but addons still cause this problem.

@Hypnosphi Hypnosphi added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants