Add tslint to the linting pipe #2682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2682 +/- ##
=======================================
Coverage 34.35% 34.35%
=======================================
Files 389 389
Lines 8747 8747
Branches 897 898 +1
=======================================
Hits 3005 3005
+ Misses 5144 5134 -10
- Partials 598 608 +10
Continue to review full report at Codecov.
|
igor-dv
added
compatibility with other tools
maintenance
Hypnosphi
reviewed
Jan 8, 2018
| "lint:js": "cross-env NODE_ENV=production eslint --cache --cache-location=.cache/eslint --ext .js,.jsx,.json", | ||
| "lint:ts": "tslint -p . -t stylish -e '{**/node_modules/**,**/dist/**,lib/cli/test/**,**/storybook-static/**}' **/*.ts", |
There was a problem hiding this comment.
do they have something like .tslintignore?
shilman
added
the
patch:yes
|
adding to patch to reduce merge conflicts |
shilman
pushed a commit
that referenced
this pull request
Jan 10, 2018
Add tslint to the linting pipe
Hypnosphi
added
the
patch:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Based on #2679 (comment)
What I did
Added tslint to the precommit + fixed linter errors.
Feel free to add new rules.