Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add entry components to modulemetadata - #2701 #2702

Merged
merged 1 commit into from
Jan 9, 2018

Conversation

amcdnl
Copy link
Member

@amcdnl amcdnl commented Jan 9, 2018

This issue addresses #2701

It adds the ability to pass entryComponents to the module metadata object.

@amcdnl amcdnl self-assigned this Jan 9, 2018
@amcdnl amcdnl requested review from alterx and igor-dv January 9, 2018 18:29
@codecov
Copy link

codecov bot commented Jan 9, 2018

Codecov Report

Merging #2702 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2702   +/-   ##
=======================================
  Coverage   34.35%   34.35%           
=======================================
  Files         389      389           
  Lines        8747     8747           
  Branches      899      910   +11     
=======================================
  Hits         3005     3005           
- Misses       5128     5129    +1     
+ Partials      614      613    -1
Impacted Files Coverage Δ
app/react/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/react/src/server/utils.js 0% <0%> (-53.58%) ⬇️
addons/a11y/src/components/Report/index.js 0% <0%> (ø) ⬆️
...dons/actions/src/lib/types/object/getObjectName.js 62.5% <0%> (ø) ⬆️
lib/ui/src/modules/ui/components/layout/index.js 29.28% <0%> (ø) ⬆️
...res__/update-addon-info/update-addon-info.input.js 0% <0%> (ø) ⬆️
addons/actions/src/lib/util/typeReplacer.js 54.54% <0%> (ø) ⬆️
lib/core/src/client/preview/config_api.js 46.55% <0%> (ø) ⬆️
app/react-native/src/bin/storybook.js 0% <0%> (ø) ⬆️
app/react-native/src/bin/storybook-start.js 0% <0%> (ø) ⬆️
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 748e494...4041ddc. Read the comment docs.

@alterx
Copy link
Member

alterx commented Jan 9, 2018

LGTM

@igor-dv igor-dv added angular patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jan 9, 2018
@igor-dv igor-dv merged commit a5d439c into storybookjs:master Jan 9, 2018
@amcdnl amcdnl deleted the entry-comps branch January 9, 2018 19:01
shilman pushed a commit that referenced this pull request Jan 10, 2018
fix: add entry components to modulemetadata - #2701
@Hypnosphi Hypnosphi added patch:done Patch/release PRs already cherry-picked to main/release branch and removed patch:done Patch/release PRs already cherry-picked to main/release branch labels Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
angular patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants