Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-backgrounds: remove redundant scrollbars #2744

Merged
merged 3 commits into from
Jan 14, 2018

Conversation

Hypnosphi
Copy link
Member

@Hypnosphi Hypnosphi commented Jan 13, 2018

Fixes the first part of #2655

How to test

Open addon-backgrounds example

Note for mac users: to see the difference, you may need to go to Settings -> General and select "Always" as "Show scroll bars" option

@Hypnosphi Hypnosphi requested a review from a team January 13, 2018 22:04
@Hypnosphi Hypnosphi added addon: backgrounds bug patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jan 13, 2018
@codecov
Copy link

codecov bot commented Jan 13, 2018

Codecov Report

Merging #2744 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2744   +/-   ##
=======================================
  Coverage   33.02%   33.02%           
=======================================
  Files         419      419           
  Lines        9158     9158           
  Branches      971      971           
=======================================
  Hits         3024     3024           
  Misses       5485     5485           
  Partials      649      649
Impacted Files Coverage Δ
addons/background/src/index.js 86.36% <ø> (ø) ⬆️
app/react/src/server/utils.js 0% <0%> (-53.58%) ⬇️
app/vue/src/server/utils.js 53.57% <0%> (+53.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3416311...71a9f83. Read the comment docs.

@ndelangen
Copy link
Member

Merge when ready

@Hypnosphi Hypnosphi merged commit 20af34a into master Jan 14, 2018
@Hypnosphi Hypnosphi deleted the backgrounds-scrollbars branch January 14, 2018 00:31
shilman pushed a commit that referenced this pull request Jan 19, 2018
Addon-backgrounds: remove redundant scrollbars
@Hypnosphi Hypnosphi added patch:done Patch/release PRs already cherry-picked to main/release branch and removed patch:done Patch/release PRs already cherry-picked to main/release branch labels Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: backgrounds bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants