Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove entryComponents prop from metadata #2790

Merged
merged 2 commits into from
Jan 20, 2018

Conversation

Quramy
Copy link
Contributor

@Quramy Quramy commented Jan 20, 2018

Issue:

It seems that entryComponents is not reeded the Angular example's story.
It's misleading and users may think entryComponents is required to use template.

What I did

  • remove the prop from example stories' metadata

@codecov
Copy link

codecov bot commented Jan 20, 2018

Codecov Report

Merging #2790 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2790   +/-   ##
=======================================
  Coverage   35.51%   35.51%           
=======================================
  Files         434      434           
  Lines        9501     9501           
  Branches      997     1019   +22     
=======================================
  Hits         3374     3374           
+ Misses       5455     5440   -15     
- Partials      672      687   +15
Impacted Files Coverage Δ
app/polymer/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/polymer/src/server/babel_config.js 0% <0%> (-76.67%) ⬇️
lib/ui/src/modules/ui/routes.js 0% <0%> (ø) ⬆️
lib/core/src/client/preview/config_api.js 46.55% <0%> (ø) ⬆️
addons/events/src/components/Event.js 38.55% <0%> (ø) ⬆️
addons/viewport/src/components/RotateViewport.js 22.72% <0%> (ø) ⬆️
addons/info/src/components/PropTable.js 87.23% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/layout.js 12.5% <0%> (ø) ⬆️
...ddons/actions/src/containers/ActionLogger/index.js 49.25% <0%> (ø) ⬆️
lib/ui/src/modules/ui/components/shortcuts_help.js 12.85% <0%> (ø) ⬆️
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bc13f7...cdc9c9f. Read the comment docs.

@igor-dv igor-dv merged commit 4886eff into storybookjs:master Jan 20, 2018
@Quramy Quramy deleted the angular-example-remove-entries branch January 20, 2018 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants