-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add watch mode for build-storybook #2866
add watch mode for build-storybook #2866
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2866 +/- ##
==========================================
- Coverage 35.81% 35.73% -0.08%
==========================================
Files 428 428
Lines 9424 9444 +20
Branches 963 989 +26
==========================================
Hits 3375 3375
- Misses 5404 5417 +13
- Partials 645 652 +7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks reasonable to me. I will test it later today.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested. LGTM.
Issue: #2762
What I did
Added
-w --watch
option forbuild-storybook
.How to test
Link storybook to an existing app, run
build-storybook --watch
. Watch should be enabled.Is this testable with jest or storyshots?
No.
Does this need a new example in the kitchen sink apps?
Not sure / don't think so.
Does this need an update to the documentation?
Yes
If your answer is yes to any of these, please make sure to include it in your PR.