Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix browser navigation again #2870

Merged
merged 1 commit into from
Jan 30, 2018
Merged

Fix browser navigation again #2870

merged 1 commit into from
Jan 30, 2018

Conversation

Hypnosphi
Copy link
Member

Issue: #2868

Looks like using pushState in iframe creates new history entries in parent window

@Hypnosphi Hypnosphi requested a review from tmeasday January 29, 2018 22:30
@Hypnosphi Hypnosphi added bug patch:yes Bugfix & documentation PR that need to be picked to main branch core labels Jan 29, 2018
@codecov
Copy link

codecov bot commented Jan 29, 2018

Codecov Report

Merging #2870 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2870   +/-   ##
=======================================
  Coverage   35.82%   35.82%           
=======================================
  Files         428      428           
  Lines        9423     9423           
  Branches      975      989   +14     
=======================================
  Hits         3376     3376           
+ Misses       5400     5390   -10     
- Partials      647      657   +10
Impacted Files Coverage Δ
lib/core/src/client/preview/syncUrlWithStore.js 40.9% <0%> (ø) ⬆️
app/polymer/src/server/config/babel.js 0% <0%> (-100%) ⬇️
...es__/update-addon-info/update-addon-info.output.js 0% <0%> (ø) ⬆️
lib/core/src/client/manager/provider.js 0% <0%> (ø) ⬆️
lib/core/src/client/manager/index.js 0% <0%> (ø) ⬆️
lib/core/src/server/config/env.js 0% <0%> (ø) ⬆️
lib/components/src/table/table.js 83.33% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/routed_link.js 22.72% <0%> (ø) ⬆️
lib/core/src/client/manager/preview.js 0% <0%> (ø) ⬆️
addons/a11y/src/components/Report/Item.js 0% <0%> (ø) ⬆️
... and 62 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ea7273...850e48d. Read the comment docs.

Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm this works.

Good job.

@Hypnosphi Hypnosphi merged commit 4208dd1 into master Jan 30, 2018
@Hypnosphi Hypnosphi deleted the urlsync-replace-state branch January 30, 2018 09:40
shilman pushed a commit that referenced this pull request Feb 1, 2018
@Hypnosphi Hypnosphi added patch:done Patch/release PRs already cherry-picked to main/release branch and removed patch:done Patch/release PRs already cherry-picked to main/release branch labels Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug core patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants