Fix "dev" script to be cross-platform #2922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2922 +/- ##
=======================================
Coverage 35.99% 35.99%
=======================================
Files 429 429
Lines 9503 9503
Branches 972 976 +4
=======================================
Hits 3421 3421
+ Misses 5448 5423 -25
- Partials 634 659 +25
Continue to review full report at Codecov.
|
|
Thanks, will test |
Hypnosphi
reviewed
Feb 6, 2018
package.json
Outdated
| @@ -16,8 +16,8 @@ | |||
| "coverage": "codecov", | |||
| "danger": "danger", | |||
| "dev": "concurrently --kill-others \"yarn dev:ts\" \"yarn dev:js\"", | |||
| "dev:js": "lerna exec --parallel -- node %LERNA_ROOT_PATH%/scripts/watch-js.js", | |||
| "dev:ts": "lerna exec --parallel -- node %LERNA_ROOT_PATH%/scripts/watch-ts.js", | |||
| "dev:js": "lerna exec --parallel -- cross-env-shell node $LERNA_ROOT_PATH/scripts/watch-js.js", | |||
There was a problem hiding this comment.
It fails unless I replace $ with \\$
Hypnosphi
approved these changes
Feb 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: After my changes in "ts distribution", the
devscript works only in windowsWhat I did
I've used cross-env-shell to fix this.