Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs on LinkTo in addon-links #2926

Merged
merged 2 commits into from
Feb 6, 2018
Merged

Conversation

simon360
Copy link
Contributor

@simon360 simon360 commented Feb 6, 2018

The existing docs didn't provide correct examples of how to use LinkTo - it should be the default import from @storybook/addon-links/react, but was documented as a named import from @storybook/addon-links.

Issue: N/A

What I did

Updated the example code in adoon-links, because the reference to LinkTo wouldn't work when used.

How to test

Is this testable with jest or storyshots? No

Does this need a new example in the kitchen sink apps? No

Does this need an update to the documentation? It's purely a documentation update

If your answer is yes to any of these, please make sure to include it in your PR.

The existing docs didn't provide correct examples of how to use LinkTo - it should be the default import from `@storybook/addon-links/react`, but was documented as a named import from `@storybook/addon-links`.
@codecov
Copy link

codecov bot commented Feb 6, 2018

Codecov Report

Merging #2926 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2926   +/-   ##
=======================================
  Coverage   35.99%   35.99%           
=======================================
  Files         429      429           
  Lines        9503     9503           
  Branches      975      972    -3     
=======================================
  Hits         3421     3421           
- Misses       5428     5441   +13     
+ Partials      654      641   -13
Impacted Files Coverage Δ
app/react/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/react/src/server/babel_config.js 0% <0%> (-76.67%) ⬇️
app/vue/src/server/utils.js 0% <0%> (-53.58%) ⬇️
lib/core/src/client/manager/preview.js 0% <0%> (ø) ⬆️
app/react/src/client/preview/element_check.js 67.64% <0%> (ø) ⬆️
addons/knobs/src/components/types/Select.js 24.63% <0%> (ø) ⬆️
...t-native/src/preview/components/StoryView/index.js 0% <0%> (ø) ⬆️
...react-native/src/manager/components/PreviewHelp.js 0% <0%> (ø) ⬆️
addons/jest/src/components/Indicator.js 0% <0%> (ø) ⬆️
...s/actions/src/lib/types/function/createFunction.js 53.33% <0%> (ø) ⬆️
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95c6b09...ac64ce3. Read the comment docs.

@Hypnosphi
Copy link
Member

Thanks @simon360, I totally forgot to update the docs

@Hypnosphi Hypnosphi merged commit 71b67db into storybookjs:master Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants