Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core & UI: upgrade events from 1.1.1 to 2.0.0 #3075

Merged
merged 2 commits into from
Feb 27, 2018
Merged

Conversation

Hypnosphi
Copy link
Member

Fixes #2906

Changelog

We don't use EventEmitter#listeners anywhere, so we're safe to upgrade

@codecov
Copy link

codecov bot commented Feb 24, 2018

Codecov Report

Merging #3075 into master will decrease coverage by 0.48%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3075      +/-   ##
=========================================
- Coverage   36.08%   35.6%   -0.49%     
=========================================
  Files         438     420      -18     
  Lines        9447    9889     +442     
  Branches      880     808      -72     
=========================================
+ Hits         3409    3521     +112     
- Misses       5489    5919     +430     
+ Partials      549     449     -100
Impacted Files Coverage Δ
addons/knobs/src/angular/utils.js 74.19% <0%> (-7.95%) ⬇️
addons/knobs/src/angular/helpers.js 72.78% <0%> (-4.19%) ⬇️
lib/core/src/client/preview/syncUrlWithStore.js 39.13% <0%> (-1.78%) ⬇️
lib/core/src/client/preview/config_api.js 45.76% <0%> (-0.79%) ⬇️
addons/notes/src/register.js 0% <0%> (ø) ⬆️
addons/a11y/src/components/Report/Tags.js 0% <0%> (ø) ⬆️
lib/core/src/client/manager/preview.js 0% <0%> (ø) ⬆️
lib/cli/lib/has_yarn.js 0% <0%> (ø) ⬆️
.../core/src/server/config/defaults/webpack.config.js 0% <0%> (ø) ⬆️
app/vue/src/server/config/webpack.config.prod.js 0% <0%> (ø) ⬆️
... and 208 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e000d4a...7516d7f. Read the comment docs.

@Hypnosphi Hypnosphi merged commit 3e8462b into master Feb 27, 2018
@Hypnosphi Hypnosphi deleted the upgrade-events branch February 27, 2018 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants