Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: upgrade autoprefixer from 7.2.6 to 8.0.0 & allow configuring browser list externally #3076

Merged
merged 7 commits into from
Mar 20, 2018

Conversation

Hypnosphi
Copy link
Member

@Hypnosphi Hypnosphi commented Feb 24, 2018

Fixes: #2971

The recommended way of configuring browser targets for autoprefixer is using browserlist config on app level, see https://github.com/postcss/autoprefixer#browsers

If user doesn't have those, they'll just get the browserlist defaults, which are quite sane:
http://browserl.ist/

You can compare them with what we have currently, it's 91.47 vs 92.75 % global usage:
http://browserl.ist/?q=%3E1%25%2C+last+4+versions%2C+Firefox+ESR%2C+not+ie+%3C+9

@codecov
Copy link

codecov bot commented Feb 24, 2018

Codecov Report

Merging #3076 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3076   +/-   ##
=======================================
  Coverage   35.86%   35.86%           
=======================================
  Files         440      440           
  Lines        9682     9682           
  Branches      912      927   +15     
=======================================
  Hits         3472     3472           
+ Misses       5625     5606   -19     
- Partials      585      604   +19
Impacted Files Coverage Δ
.../core/src/server/config/defaults/webpack.config.js 0% <ø> (ø) ⬆️
app/react/src/server/utils.js 0% <0%> (-100%) ⬇️
.../ui/src/modules/ui/components/layout/dimensions.js 15.62% <0%> (ø) ⬆️
addons/actions/src/lib/types/nan/index.js 82.35% <0%> (ø) ⬆️
lib/core/src/server/build-static.js 0% <0%> (ø) ⬆️
addons/info/src/components/markdown/pre/pre.js 77.58% <0%> (ø) ⬆️
addons/storysource/src/loader/parse-helpers.js 48.33% <0%> (ø) ⬆️
lib/ui/src/modules/ui/routes.js 0% <0%> (ø) ⬆️
addons/storyshots/src/vue/renderTree.js 60% <0%> (ø) ⬆️
...ddons/actions/src/components/ActionLogger/index.js 0% <0%> (ø) ⬆️
... and 62 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6154e36...bd4198f. Read the comment docs.

# Conflicts:
#	app/angular/package.json
#	app/polymer/package.json
Copy link
Member

@danielduan danielduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's nice to let someone else worry about the defaults.

@Hypnosphi Hypnosphi added this to the v4.0.0 milestone Feb 27, 2018
@Hypnosphi Hypnosphi merged commit 6aeea45 into master Mar 20, 2018
@Hypnosphi Hypnosphi deleted the upgrade-autoprefixer branch March 20, 2018 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants