Fix links examples #3096
Merged
Fix links examples #3096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3096 +/- ##
=======================================
Coverage 36.08% 36.08%
=======================================
Files 438 438
Lines 9447 9447
Branches 872 909 +37
=======================================
Hits 3409 3409
+ Misses 5492 5463 -29
- Partials 546 575 +29
Continue to review full report at Codecov.
|
Hypnosphi
requested changes
Feb 25, 2018
| import { document } from 'global'; | ||
|
|
||
| storiesOf('Addon|Links', module).add('Go to welcome', () => { | ||
| const el = document.createElement('playground-button'); |
There was a problem hiding this comment.
Let's use some other element, it's quite weird right now: https://deploy-preview-3096--storybooks-polymer.netlify.com/?selectedKind=Addon%7CLinks&selectedStory=Go%20to%20welcome&full=0&addons=1&stories=1&panelRight=0&addonPanel=storybook%2Fstories%2Fstories-panel
…ddons + link Welcom to button
Hypnosphi
approved these changes
Feb 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Vue, Angular, and Polymer lacked
addon-linksexampleWhat I did
Added few examples