Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use WatchMissingNodeModulesPlugin from react-dev-utils package #3141

Merged
merged 1 commit into from
Mar 4, 2018

Conversation

Hypnosphi
Copy link
Member

There's no actual need to replicate it on our side.

This also adds the plugin to RN app. Actually, most of the differences between RN and React webpack configs comes from the fact that changes to React weren't applied to RN

@codecov
Copy link

codecov bot commented Mar 4, 2018

Codecov Report

Merging #3141 into master will increase coverage by 0.05%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3141      +/-   ##
==========================================
+ Coverage    36.1%   36.15%   +0.05%     
==========================================
  Files         438      437       -1     
  Lines        9443     9429      -14     
  Branches      888      914      +26     
==========================================
  Hits         3409     3409              
+ Misses       5470     5434      -36     
- Partials      564      586      +22
Impacted Files Coverage Δ
app/polymer/src/server/config/webpack.config.js 0% <ø> (ø) ⬆️
app/vue/src/server/config/webpack.config.js 0% <ø> (ø) ⬆️
app/react/src/server/config/webpack.config.js 0% <ø> (ø) ⬆️
app/angular/src/server/config/webpack.config.js 0% <ø> (ø) ⬆️
lib/core/server.js 0% <ø> (ø) ⬆️
app/react-native/src/server/config/utils.js 0% <0%> (ø) ⬆️
...p/react-native/src/server/config/webpack.config.js 0% <0%> (ø) ⬆️
app/vue/src/server/utils.js 0% <0%> (-100%) ⬇️
addons/jest/src/hoc/provideJestResult.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/types/Array.js 34.14% <0%> (ø) ⬆️
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c1ad79...276c56f. Read the comment docs.

@Hypnosphi Hypnosphi merged commit 83aac95 into master Mar 4, 2018
@Hypnosphi Hypnosphi deleted the use-external-watch-node-modules branch March 4, 2018 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants