-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[STORYSOURCE] Add ability to select stories from inside of the StoryPanel #3154
[STORYSOURCE] Add ability to select stories from inside of the StoryPanel #3154
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3154 +/- ##
==========================================
- Coverage 36.16% 36.03% -0.13%
==========================================
Files 437 437
Lines 9430 9464 +34
Branches 870 905 +35
==========================================
Hits 3410 3410
- Misses 5475 5480 +5
- Partials 545 574 +29
Continue to review full report at Codecov.
|
addons/storysource/src/StoryPanel.js
Outdated
} | ||
|
||
return ( | ||
<div |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not just use button
tag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's semantically more like an anchor than a button so maybe a
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checked and resetting a button to look like a div - is hell...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say that making div behave as a button is hell =)
I think it's semantically more like an anchor than a button so maybe
a
?
Cool idea as soon as you attach a valid href
. You may want to use RoutedLink
component from @storybook/components
to avoid page reload on plain left clicks
What I did
I've added the navigation from within the addon-storysource panel.
Since it's still in alpha, I'm not sure whether this is a feature request or not.