Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STORYSOURCE] Add ability to select stories from inside of the StoryPanel #3154

Merged
merged 3 commits into from
Mar 6, 2018

Conversation

igor-dv
Copy link
Member

@igor-dv igor-dv commented Mar 6, 2018

What I did

I've added the navigation from within the addon-storysource panel.

Since it's still in alpha, I'm not sure whether this is a feature request or not.

@igor-dv igor-dv self-assigned this Mar 6, 2018
@codecov
Copy link

codecov bot commented Mar 6, 2018

Codecov Report

Merging #3154 into master will decrease coverage by 0.12%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3154      +/-   ##
==========================================
- Coverage   36.16%   36.03%   -0.13%     
==========================================
  Files         437      437              
  Lines        9430     9464      +34     
  Branches      870      905      +35     
==========================================
  Hits         3410     3410              
- Misses       5475     5480       +5     
- Partials      545      574      +29
Impacted Files Coverage Δ
addons/storysource/src/preview.js 0% <ø> (ø) ⬆️
addons/storysource/src/StoryPanel.js 0% <0%> (ø) ⬆️
addons/storysource/src/manager.js 0% <0%> (ø) ⬆️
app/polymer/src/server/utils.js 0% <0%> (-100%) ⬇️
addons/jest/src/components/Result.js 0% <0%> (ø) ⬆️
addons/a11y/src/components/Report/Elements.js 0% <0%> (ø) ⬆️
app/react/src/client/preview/element_check.js 67.64% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/handle_routing.js 24.21% <0%> (ø) ⬆️
addons/actions/src/lib/types/symbol/index.js 81.25% <0%> (ø) ⬆️
addons/a11y/src/components/Report/Item.js 0% <0%> (ø) ⬆️
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cad6153...e3e23bd. Read the comment docs.

@igor-dv igor-dv changed the title [STORYSOURCe] Add ability to select stories from inside of the StoryPanel [STORYSOURCE] Add ability to select stories from inside of the StoryPanel Mar 6, 2018
}

return (
<div
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not just use button tag?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's semantically more like an anchor than a button so maybe a ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checked and resetting a button to look like a div - is hell...

Copy link
Member

@Hypnosphi Hypnosphi Mar 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say that making div behave as a button is hell =)

I think it's semantically more like an anchor than a button so maybe a?

Cool idea as soon as you attach a valid href. You may want to use RoutedLink component from @storybook/components to avoid page reload on plain left clicks

@ndelangen ndelangen merged commit c94bcdd into master Mar 6, 2018
@Hypnosphi Hypnosphi deleted the addon-storysource-select-story-from-the-panel branch March 6, 2018 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants