-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update links of the live examples for the new release #3197
Conversation
README.md
Outdated
- [React Official](https://release-3-4--storybooks-official.netlify.com) | ||
- [Vue](https://release-3-4--storybooks-vue.netlify.com/) | ||
- [Angular](https://release-3-4--storybooks-angular.netlify.com/) | ||
- [Polymer](https://release-3-4--storybooks-polymer.netlify.com/) | ||
|
||
### 3.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove it. I think it only make sense to have links to latest and alpha versions here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like for people with the older versions it will be a useful thing. At least to compare what they are missing, or how something changed...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, are we remaining on the "master as a release branch" strategy? I just can add the links to muster instead of the TBD.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, we've decided that master will be 4.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just can add the links to muster instead of the TBD.
Now you can. 3.4 is in release/3.4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
@tmeasday is there a chance that Chromatic has forgotten all our screenshots for some reason? |
@Hypnosphi thanks for bringing this to my attention. I think it is a bug at our end, in the meantime I will just approve all on this particular build. Let me know if you see it again. |
Codecov Report
@@ Coverage Diff @@
## master #3197 +/- ##
==========================================
+ Coverage 35.61% 35.98% +0.36%
==========================================
Files 442 437 -5
Lines 9777 9474 -303
Branches 911 893 -18
==========================================
- Hits 3482 3409 -73
+ Misses 5706 5484 -222
+ Partials 589 581 -8
Continue to review full report at Codecov.
|
Update links of the live examples for the new release
What I did
I've updated links for the live examples. Probably should be merged after the release and when we will have a dedicated branch for the 3.4.