Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update links of the live examples for the new release #3197

Merged
merged 3 commits into from
Mar 22, 2018

Conversation

igor-dv
Copy link
Member

@igor-dv igor-dv commented Mar 13, 2018

What I did

I've updated links for the live examples. Probably should be merged after the release and when we will have a dedicated branch for the 3.4.

@igor-dv igor-dv self-assigned this Mar 13, 2018
README.md Outdated
- [React Official](https://release-3-4--storybooks-official.netlify.com)
- [Vue](https://release-3-4--storybooks-vue.netlify.com/)
- [Angular](https://release-3-4--storybooks-angular.netlify.com/)
- [Polymer](https://release-3-4--storybooks-polymer.netlify.com/)

### 3.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove it. I think it only make sense to have links to latest and alpha versions here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like for people with the older versions it will be a useful thing. At least to compare what they are missing, or how something changed...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, are we remaining on the "master as a release branch" strategy? I just can add the links to muster instead of the TBD.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we've decided that master will be 4.0

Copy link
Member

@Hypnosphi Hypnosphi Mar 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just can add the links to muster instead of the TBD.

Now you can. 3.4 is in release/3.4

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@Hypnosphi Hypnosphi added this to the v4.0.0 milestone Mar 13, 2018
@Hypnosphi
Copy link
Member

@tmeasday is there a chance that Chromatic has forgotten all our screenshots for some reason?

@tmeasday
Copy link
Member

@Hypnosphi thanks for bringing this to my attention. I think it is a bug at our end, in the meantime I will just approve all on this particular build. Let me know if you see it again.

@codecov
Copy link

codecov bot commented Mar 13, 2018

Codecov Report

Merging #3197 into master will increase coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3197      +/-   ##
==========================================
+ Coverage   35.61%   35.98%   +0.36%     
==========================================
  Files         442      437       -5     
  Lines        9777     9474     -303     
  Branches      911      893      -18     
==========================================
- Hits         3482     3409      -73     
+ Misses       5706     5484     -222     
+ Partials      589      581       -8
Impacted Files Coverage Δ
lib/core/src/client/preview/client_api.js 90.81% <0%> (-2.12%) ⬇️
lib/core/src/client/preview/story_store.js 84.21% <0%> (-0.75%) ⬇️
app/vue/src/client/preview/index.js 0% <0%> (ø) ⬆️
addons/a11y/src/components/Report/Elements.js 0% <0%> (ø) ⬆️
addons/knobs/src/react/WrapStory.js 49.42% <0%> (ø) ⬆️
...tive/src/preview/components/StoryListView/index.js 0% <0%> (ø) ⬆️
...tions/src/lib/types/function/createFunctionEval.js 77.77% <0%> (ø) ⬆️
addons/info/src/components/types/Shape.js 66.03% <0%> (ø) ⬆️
addons/a11y/src/components/Report/index.js 0% <0%> (ø) ⬆️
app/react-native/src/preview/index.js 0% <0%> (ø) ⬆️
... and 96 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 100ea0f...4044fce. Read the comment docs.

@Hypnosphi Hypnosphi merged commit 4cfe34a into master Mar 22, 2018
@Hypnosphi Hypnosphi deleted the new-live-examples branch March 22, 2018 15:06
@Hypnosphi Hypnosphi added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Mar 29, 2018
Hypnosphi added a commit that referenced this pull request Mar 29, 2018
Update links of the live examples for the new release
@Hypnosphi Hypnosphi added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants