Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example for @ngrx/store #3233

Merged
merged 2 commits into from
Mar 18, 2018
Merged

Add example for @ngrx/store #3233

merged 2 commits into from
Mar 18, 2018

Conversation

igor-dv
Copy link
Member

@igor-dv igor-dv commented Mar 18, 2018

Issue: Angular people are using https://github.com/ngrx a lot. I think it is nice to have a dedicated section in examples with issues regarding the ngrx.

What I did

Added an example for @ngrx/store. CC #3217

@codecov
Copy link

codecov bot commented Mar 18, 2018

Codecov Report

Merging #3233 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3233   +/-   ##
=======================================
  Coverage   35.95%   35.95%           
=======================================
  Files         437      437           
  Lines        9473     9473           
  Branches      874      890   +16     
=======================================
  Hits         3406     3406           
+ Misses       5514     5508    -6     
- Partials      553      559    +6
Impacted Files Coverage Δ
app/polymer/src/server/utils.js 0% <0%> (-100%) ⬇️
lib/ui/src/modules/ui/components/shortcuts_help.js 12.85% <0%> (ø) ⬆️
lib/ui/src/libs/withLifecycleDecorator.js 17.14% <0%> (ø) ⬆️
addons/actions/src/lib/util/typeReplacer.js 54.54% <0%> (ø) ⬆️
addons/a11y/src/components/WrapStory.js 61.11% <0%> (ø) ⬆️
addons/info/src/components/PropVal.js 84.25% <0%> (ø) ⬆️
addons/knobs/src/components/types/Color.js 8.1% <0%> (ø) ⬆️
lib/core/src/client/preview/story_store.js 84.21% <0%> (ø) ⬆️
addons/info/src/components/types/OneOfType.js 60% <0%> (ø) ⬆️
addons/graphql/src/components/FullScreen/index.js 0% <0%> (ø) ⬆️
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c60a6aa...13f3366. Read the comment docs.

@Hypnosphi
Copy link
Member

Hypnosphi commented Mar 18, 2018

@tmeasday it's happening again: screenshots are lost
https://www.chromaticqa.com/build?appId=5a375b97f4b14f0020b0cda3&number=1507

@Hypnosphi Hypnosphi merged commit 59eabba into master Mar 18, 2018
@Hypnosphi Hypnosphi deleted the example-with-ngrx-store branch March 18, 2018 14:44
@tmeasday
Copy link
Member

@Hypnosphi thanks! I'm pretty sure this is due to a bug that we have fixed and will be releasing soon after a little more testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants