Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue when extending webpack config #3279

Merged
merged 1 commit into from
Mar 25, 2018

Conversation

benbakhar
Copy link
Contributor

Issue: #3215

What I did

Fix bug when property lookup is performed on undefined object

How to test

Run storybook after extending the webpack config with the following (Assumes jquery is installed):

webpack.config.js:

const webpack = require('webpack');

module.exports = {
  plugins: [
    new webpack.ProvidePlugin({
      $: 'jquery',
    }),
  ],
};

@benbakhar benbakhar changed the title protect property loookup Fix issue when extending webpack config Mar 25, 2018
Copy link
Member

@igor-dv igor-dv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Though #3261 will fix it in common

@igor-dv igor-dv added vue patch:yes Bugfix & documentation PR that need to be picked to main branch bug labels Mar 25, 2018
@igor-dv igor-dv merged commit c74e085 into storybookjs:master Mar 25, 2018
@Hypnosphi
Copy link
Member

Do angular and polymer apps need the same fix for 3.4.0?

@igor-dv
Copy link
Member

igor-dv commented Mar 26, 2018

Probably they do

@benbakhar benbakhar deleted the fix-extend-vue-webpak-config branch March 26, 2018 08:30
@Hypnosphi Hypnosphi added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 29, 2018
Hypnosphi pushed a commit that referenced this pull request Mar 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch vue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants