-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: adding aXe configuration for a11y addon #3285
Conversation
addons/a11y/src/index.js
Outdated
} | ||
|
||
export { checkA11y, shared }; | ||
function configure(options = {}) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
configure
is a too generic name. Please rename it to the configureA11y
.
Codecov Report
@@ Coverage Diff @@
## master #3285 +/- ##
==========================================
- Coverage 36.09% 36.05% -0.04%
==========================================
Files 445 445
Lines 9783 9793 +10
Branches 902 890 -12
==========================================
Hits 3531 3531
- Misses 5669 5707 +38
+ Partials 583 555 -28
Continue to review full report at Codecov.
|
1744e56
to
26e430e
Compare
@igor-dv @Hypnosphi updated :) |
Issue: #2830
What I did
Added an extra export function
configure
to the a11y addon for users to configure aXeusage:
How to test
I used the official storybook to test configuring axe.
Is this testable with jest or storyshots?
N
Does this need a new example in the kitchen sink apps?
N
Does this need an update to the documentation?
Y
If your answer is yes to any of these, please make sure to include it in your PR.