-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Addon-storyshots] Remove default options on "goto" call #3298
[Addon-storyshots] Remove default options on "goto" call #3298
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3298 +/- ##
=======================================
Coverage 36.09% 36.09%
=======================================
Files 445 445
Lines 9783 9783
Branches 906 902 -4
=======================================
Hits 3531 3531
- Misses 5655 5669 +14
+ Partials 597 583 -14
Continue to review full report at Codecov.
|
addons/storyshots/README.md
Outdated
|
||
```js | ||
import initStoryshots, { imageSnapshot } from '@storybook/addon-storyshots'; | ||
const getGotoOptions = ({context, url}) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing arrow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow so bad ! Thanks !
e7d6ab7
to
9713b4a
Compare
@Hypnosphi that's fixed, thanks for the review ! |
…t-goto-options [Addon-storyshots] Remove default options on "goto" call
Issue: #3288
What I did
goto
call (puppeteer API) viagetGotoOptions
argument on theimageSnapshot
storyshot method.How to test
yarn test --image
Why
goto
puppeteer method