jest-image-snapshot version to ^2.4.1 #3500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skywhale
requested review from
Hypnosphi,
igor-dv and
thomasbertet
as code owners
Hypnosphi
approved these changes
Apr 29, 2018
Hypnosphi
added
the
patch:yes
Hypnosphi
added a commit
that referenced
this pull request
May 4, 2018
jest-image-snapshot version to ^2.4.1
Hypnosphi
added
the
patch:done
This was referenced Jun 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
JSON.stringify failing inside jest-image-snapshot with Node 9
What I did
Rollup jest-image-snapshot to include americanexpress/jest-image-snapshot#72
How to test
Is this testable with Jest or Chromatic screenshots? no
Does this need a new example in the kitchen sink apps? no
Does this need an update to the documentation? no
If your answer is yes to any of these, please make sure to include it in your PR.