Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Replace decorate with decorateAction" #3600

Merged
merged 1 commit into from
May 23, 2018
Merged

Conversation

Hypnosphi
Copy link
Member

Reverts #3538

Sorry, I overlooked this one. The thing is, decorate was introduced and decorateAction deprecated (not formally though) in #3352

@fvilers docs for stable version are here: https://github.com/storybooks/storybook/tree/release/3.4/addons/knobs

@Hypnosphi Hypnosphi requested a review from rhalff as a code owner May 17, 2018 18:01
@Hypnosphi Hypnosphi added the maintenance User-facing maintenance tasks label May 17, 2018
@codecov
Copy link

codecov bot commented May 17, 2018

Codecov Report

Merging #3600 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3600   +/-   ##
=======================================
  Coverage   36.48%   36.48%           
=======================================
  Files         490      490           
  Lines       10271    10271           
  Branches      943      952    +9     
=======================================
  Hits         3747     3747           
+ Misses       5962     5933   -29     
- Partials      562      591   +29
Impacted Files Coverage Δ
addons/a11y/src/components/Report/Item.js 0% <0%> (ø) ⬆️
addons/a11y/src/components/Tabs.js 0% <0%> (ø) ⬆️
lib/components/src/table/table.js 83.33% <0%> (ø) ⬆️
addons/viewport/src/manager/components/Panel.js 37.26% <0%> (ø) ⬆️
addons/a11y/src/components/Report/RerunButton.js 0% <0%> (ø) ⬆️
addons/info/src/components/types/PropertyLabel.js 78.94% <0%> (ø) ⬆️
lib/core/src/server/utils.js 40.47% <0%> (ø) ⬆️
addons/knobs/src/components/PropField.js 10.63% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/stories_panel.js 25% <0%> (ø) ⬆️
lib/ui/src/modules/api/index.js 0% <0%> (ø) ⬆️
... and 62 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d4438b...c8a8f47. Read the comment docs.

@fvilers
Copy link
Contributor

fvilers commented May 18, 2018

@Hypnosphi Sorry about that, I was using the latest version and couldn't find decorate. I should have look at the source history.

@Hypnosphi Hypnosphi requested a review from a team May 23, 2018 18:21
@ndelangen ndelangen merged commit 6f919d0 into master May 23, 2018
@ndelangen ndelangen deleted the revert-3538-patch-1 branch May 23, 2018 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants