Few fixed related to marko support #3609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
May 18, 2018 00:26
nm123github
requested review from
Hypnosphi,
ndelangen,
shilman and
stijnkoopal
as code owners
Codecov Report
@@ Coverage Diff @@
## master #3609 +/- ##
=======================================
Coverage 40.02% 40.02%
=======================================
Files 481 481
Lines 5254 5254
Branches 862 862
=======================================
Hits 2103 2103
Misses 2634 2634
Partials 517 517Continue to review full report at Codecov.
|
Hypnosphi
reviewed
May 20, 2018
| @@ -1,2 +1,2 @@ | |||
| import '@storybook/addon-actions/register'; | |||
| import '@storybook/addon-links/register'; | |||
| import '@storybook/addon-knobs/register'; | |||
There was a problem hiding this comment.
You need to add it as dependency in MARKO/index.js then
Please run yarn test --cli --update after that
There was a problem hiding this comment.
Please also commit the new files in snapshots/marko/components (git add -A should help)
There was a problem hiding this comment.
Yes, snapshots files are part of PR.
Hypnosphi
approved these changes
May 20, 2018
|
Released as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
What I did
How to test
Is this testable with Jest or Chromatic screenshots?
Not sure
Does this need a new example in the kitchen sink apps?
Added new example.
Does this need an update to the documentation?
No