-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group deprecated stories #3846
Group deprecated stories #3846
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! But I think snapshots need to be updated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for covering up what I should've done 😅🙇
…oup-deprecated-stories
Codecov Report
@@ Coverage Diff @@
## master #3846 +/- ##
=======================================
Coverage 41.56% 41.56%
=======================================
Files 455 455
Lines 5177 5177
Branches 899 899
=======================================
Hits 2152 2152
Misses 2485 2485
Partials 540 540 Continue to review full report at Codecov.
|
This is weird, it seems like the snapshots are up to date (no changes and tests pass when I run |
I dunno @tmeasday but I ran it, and it found 2 snapshots to be in need of some updating. |
Issue: Deprecated stories were muddled up with other stories.
Also: most of the info stories were still using the deprecated APIs (cc @Keraito)
What I did
Put all deprecated stories into their own sections. (Was this what you had in mind @shilman?)
How to test
Hopefully name changes are self explanatory and snapshots will match up.