Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group deprecated stories #3846

Merged
merged 5 commits into from
Jul 20, 2018
Merged

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Jul 6, 2018

Issue: Deprecated stories were muddled up with other stories.

Also: most of the info stories were still using the deprecated APIs (cc @Keraito)

What I did

Put all deprecated stories into their own sections. (Was this what you had in mind @shilman?)

How to test

Hopefully name changes are self explanatory and snapshots will match up.

@tmeasday tmeasday added the maintenance User-facing maintenance tasks label Jul 6, 2018
@tmeasday tmeasday changed the title Tmeasday/group deprecated stories Group deprecated stories Jul 6, 2018
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! But I think snapshots need to be updated?

Copy link
Contributor

@Keraito Keraito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for covering up what I should've done 😅🙇

@codecov
Copy link

codecov bot commented Jul 19, 2018

Codecov Report

Merging #3846 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3846   +/-   ##
=======================================
  Coverage   41.56%   41.56%           
=======================================
  Files         455      455           
  Lines        5177     5177           
  Branches      899      899           
=======================================
  Hits         2152     2152           
  Misses       2485     2485           
  Partials      540      540

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b6e508...d2c3c64. Read the comment docs.

@tmeasday
Copy link
Member Author

This is weird, it seems like the snapshots are up to date (no changes and tests pass when I run yarn test --core --update on the branch), yet the builds still fail. Anyone have any idea?

@ndelangen
Copy link
Member

I dunno @tmeasday but I ran it, and it found 2 snapshots to be in need of some updating.

@ndelangen ndelangen merged commit 0e565c0 into master Jul 20, 2018
@ndelangen ndelangen deleted the tmeasday/group-deprecated-stories branch July 20, 2018 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants