Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MOVE ui into it's own group #3884

Merged
merged 1 commit into from
Jul 16, 2018
Merged

MOVE ui into it's own group #3884

merged 1 commit into from
Jul 16, 2018

Conversation

ndelangen
Copy link
Member

improved the official storybook a bit so the ui section has a proper own heading

@ndelangen ndelangen added the maintenance User-facing maintenance tasks label Jul 14, 2018
@ndelangen ndelangen self-assigned this Jul 14, 2018
@codecov
Copy link

codecov bot commented Jul 14, 2018

Codecov Report

Merging #3884 into master will not change coverage.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3884   +/-   ##
=======================================
  Coverage   41.44%   41.44%           
=======================================
  Files         455      455           
  Lines        5193     5193           
  Branches      903      903           
=======================================
  Hits         2152     2152           
  Misses       2496     2496           
  Partials      545      545
Impacted Files Coverage Δ
...ui/src/modules/ui/components/search_box.stories.js 60% <0%> (ø) ⬆️
...rc/modules/ui/components/shortcuts_help.stories.js 57.14% <0%> (ø) ⬆️
.../ui/src/modules/ui/components/menu_item.stories.js 100% <100%> (ø) ⬆️
...dules/ui/components/stories_panel/index.stories.js 91.66% <100%> (ø) ⬆️
...onents/stories_panel/stories_tree/index.stories.js 94.44% <100%> (ø) ⬆️
...ui/components/stories_panel/text_filter.stories.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a588f4d...267b999. Read the comment docs.

Copy link
Member

@igor-dv igor-dv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can also remove this:

image

😳

@ndelangen ndelangen merged commit 6ca3168 into master Jul 16, 2018
@ndelangen
Copy link
Member Author

@igor-dv sure, I'll try and get that in a better shape as well soon!

@ndelangen ndelangen deleted the move-official-example-ui branch July 16, 2018 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants