addon-info: fix copy button styling #3896
Merged
+33
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adekbadek
requested review from
dangreenisrael,
danielduan,
Hypnosphi,
theinterned,
usulpro and
z4o4z
as code owners
The copy button in Story Source was shrunk when the source was too wide to fit on screen (https://monosnap.com/file/0k7rzJAxlBV9XiFLGeJnnUKs12dipg).
Codecov Report
@@ Coverage Diff @@
## master #3896 +/- ##
==========================================
- Coverage 41.56% 41.55% -0.02%
==========================================
Files 455 455
Lines 5177 5176 -1
Branches 899 898 -1
==========================================
- Hits 2152 2151 -1
Misses 2485 2485
Partials 540 540
Continue to review full report at Codecov.
|
danielduan
added
bug
patch:yes
danielduan
approved these changes
Jul 18, 2018
Hypnosphi
added
the
patch:done
Hypnosphi
pushed a commit
that referenced
this pull request
Aug 2, 2018
addon-info: fix copy button styling
This was referenced Oct 1, 2018
Update @storybook/react in /modules/frontend from 3.3.15 to 3.4.11
project-accelerate/accelerate#259
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The copy button in Story Source was shrunk when the source was too wide to fit on screen (https://monosnap.com/file/0k7rzJAxlBV9XiFLGeJnnUKs12dipg).
Issue:
What I did
added
flex-shrinkrule tocopyButtonHow to test
Is this testable with Jest or Chromatic screenshots?
Does this need a new example in the kitchen sink apps?
Does this need an update to the documentation?
If your answer is yes to any of these, please make sure to include it in your PR.
For maintainers only: Please tag your pull request with at least one of the following:
["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]