Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autodetection of used components in info addon #4004

Merged
merged 4 commits into from
Aug 24, 2018

Conversation

martinmacko47
Copy link
Contributor

Closes #3989

Fixes regression in v4.0.0-alpha.16. If propTables option is omited, addon-info used to render proptypes tables for all used components. It does not render anything in v4.0.0-alpha.16 any more. It does not render proptypes tables at all.

It was caused by a search&replace typo in 935cefd. See my comment where exactly: 935cefd#r30022947

@ndelangen ndelangen added the bug label Aug 14, 2018
@ndelangen ndelangen self-assigned this Aug 14, 2018
@ndelangen
Copy link
Member

ndelangen commented Aug 15, 2018

Thanks you, martinmacko47 !
Can you verify the snapshot change and fix it? You can do so by running the unit-tests locally and signal you want to update the snapshots.

I will merge as soon as possible.

@ndelangen
Copy link
Member

The snapshot change is what I expect, so all we have to do is accept the update (by running the tests with --update)

@szimek
Copy link

szimek commented Aug 24, 2018

@ndelangen Hi! Any chances to merge it soon? Is there anything I can do to help get it merged sooner?

I have exactly the same issue and was debugging it just to find out the commit where props.children were accidentally renamed to props.innerChildren :)

@codecov
Copy link

codecov bot commented Aug 24, 2018

Codecov Report

Merging #4004 into master will increase coverage by 48.4%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4004      +/-   ##
==========================================
+ Coverage   40.22%   88.63%   +48.4%     
==========================================
  Files         467        6     -461     
  Lines        5638       44    -5594     
  Branches      748        2     -746     
==========================================
- Hits         2268       39    -2229     
+ Misses       2994        4    -2990     
+ Partials      376        1     -375
Impacted Files Coverage Δ
addons/info/src/index.js
...s/storyshots-core/src/api/integrityTestTemplate.js
.../actions/src/lib/types/object/createNamedObject.js
addons/knobs/mithril.js
lib/core/src/client/preview/reducer.js
addons/notes/src/react.js
addons/actions/src/lib/types/nan/index.js
lib/channel-websocket/src/index.js
lib/ui/src/modules/ui/containers/search_box.js
app/html/src/client/preview/index.js
... and 450 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 887d64b...622c5c3. Read the comment docs.

@ndelangen
Copy link
Member

@szimek yeah I'll put in the effort to fix the snapshots and merge in master

@ndelangen ndelangen merged commit 447a45f into storybookjs:master Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants