-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix autodetection of used components in info addon #4004
Conversation
Thanks you, martinmacko47 ! I will merge as soon as possible. |
The snapshot change is what I expect, so all we have to do is accept the update (by running the tests with |
@ndelangen Hi! Any chances to merge it soon? Is there anything I can do to help get it merged sooner? I have exactly the same issue and was debugging it just to find out the commit where |
Codecov Report
@@ Coverage Diff @@
## master #4004 +/- ##
==========================================
+ Coverage 40.22% 88.63% +48.4%
==========================================
Files 467 6 -461
Lines 5638 44 -5594
Branches 748 2 -746
==========================================
- Hits 2268 39 -2229
+ Misses 2994 4 -2990
+ Partials 376 1 -375 Continue to review full report at Codecov.
|
@szimek yeah I'll put in the effort to fix the snapshots and merge in master |
Closes #3989
Fixes regression in v4.0.0-alpha.16. If propTables option is omited, addon-info used to render proptypes tables for all used components. It does not render anything in v4.0.0-alpha.16 any more. It does not render proptypes tables at all.
It was caused by a search&replace typo in 935cefd. See my comment where exactly: 935cefd#r30022947