feature: noStoriesOf loader option support for custome story #4012
Conversation
466023746
changed the title
| var withStorySource = require('@storybook/addon-storysource').withStorySource; | ||
| var __STORY__ = ${sourceJson}; | ||
| var __ADDS_MAP__ = ${addsMap}; | ||
|
|
||
| ${result.source} | ||
| `; | ||
| } else { | ||
| return ` | ||
| export var __STORY__ = ${sourceJson}; |
There was a problem hiding this comment.
We can export them anyway, and reduce this conditions complexity
| const result = injectDecorator(source, ADD_DECORATOR_STATEMENT, this.resourcePath, options); | ||
|
|
||
| if (!result.changed) { | ||
| if (!options.noStoriesOf && !result.changed) { |
There was a problem hiding this comment.
I think that the whole point of the feature is that you don't want to inject the decorator, but you do wont to extract the source, so let's just call this parameter injectDecorator and it will be true by default.
|
if publish, hopes notify me here, thanks |
You mean you don't want to continue this PR? |
|
ehhh..., i have thought you will change it, sorry, understand mistake. |
Codecov Report
@@ Coverage Diff @@
## master #4012 +/- ##
==========================================
+ Coverage 40.52% 40.57% +0.05%
==========================================
Files 469 469
Lines 5636 5641 +5
Branches 745 748 +3
==========================================
+ Hits 2284 2289 +5
Misses 2984 2984
Partials 368 368
Continue to review full report at Codecov.
|
| } | ||
| ); | ||
|
|
||
| it('don\'t injects stories decorator after the all "storiesOf" functions', () => { |
| } | ||
| ); | ||
|
|
||
| it('don\'t injects stories decorator after the all "storiesOf" functions', () => { |
| } | ||
| ); | ||
|
|
||
| it('don\'t injects stories decorator after the all "storiesOf" functions', () => { |
| options.parser | ||
| ); | ||
| const { injectDecorator = true } = options; | ||
| const { changed, source: newSource, comments } = injectDecorator |
There was a problem hiding this comment.
let's check it with injectDecorator === true
|
Please merge from master, it should solve CI issues. |
|
ok |
466023746
requested review from
Hypnosphi,
ndelangen,
shilman and
stijnkoopal
as code owners
Issue:#3993