Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecation of --db-path and --enable-db #4030

Merged
merged 1 commit into from
Aug 17, 2018

Conversation

igor-dv
Copy link
Member

@igor-dv igor-dv commented Aug 16, 2018

Issue: There were old --db-path and --enable-db that we forgot to remove.

@igor-dv igor-dv added maintenance User-facing maintenance tasks core labels Aug 16, 2018
@igor-dv igor-dv self-assigned this Aug 16, 2018
@codecov
Copy link

codecov bot commented Aug 16, 2018

Codecov Report

Merging #4030 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4030      +/-   ##
==========================================
+ Coverage   40.75%   40.79%   +0.04%     
==========================================
  Files         444      444              
  Lines        5565     5559       -6     
  Branches      750      748       -2     
==========================================
  Hits         2268     2268              
+ Misses       2919     2915       -4     
+ Partials      378      376       -2
Impacted Files Coverage Δ
lib/core/src/server/build-dev.js 0% <ø> (ø) ⬆️
lib/core/src/server/build-static.js 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 312d7ca...df1c4b7. Read the comment docs.

@pksunkara pksunkara merged commit 3dc23e3 into master Aug 17, 2018
@pksunkara pksunkara deleted the remove-deprecated-db-params branch August 17, 2018 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants