#3780: Do not display wrong warning when loading ".js" or ".json" #4060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igor-dv
reviewed
Aug 23, 2018
lib/core/src/server/serverRequire.js
Outdated
| @@ -84,7 +84,7 @@ export default function serverRequire(filePath) { | |||
|
|
|||
| const moduleDescriptor = interpret.extensions[candidateExt]; | |||
|
|
|||
| if (registerCompiler(moduleDescriptor) === 0) { | |||
| if (moduleDescriptor !== null && registerCompiler(moduleDescriptor) === 0) { | |||
There was a problem hiding this comment.
So, is the problem only with a .json? because there is already a check ☝️ for .js.
There was a problem hiding this comment.
Yeah, you are right. My proposition to not show the warning when moduleDescriptor is undefined (no key in interpret.extensions) or null (as for .js and .json).
Codecov Report
@@ Coverage Diff @@
## master #4060 +/- ##
==========================================
+ Coverage 40.22% 40.24% +0.01%
==========================================
Files 467 467
Lines 5638 5636 -2
Branches 748 747 -1
==========================================
Hits 2268 2268
+ Misses 2994 2993 -1
+ Partials 376 375 -1
Continue to review full report at Codecov.
|
igor-dv
approved these changes
Aug 23, 2018
|
Can you please merge from master? |
|
Done. Let's wait for the builds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #3780
Description: #3780 (comment)