Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge webpack optimisation configs #4121

Merged
merged 3 commits into from
Sep 8, 2018

Conversation

WearyMonkey
Copy link
Contributor

Issue

#4120

What I did

Merges the webpack optimisation configs.

@storybook-safe-bot
Copy link
Contributor

Fails
🚫

PR is not labeled with one of: ["cleanup","BREAKING CHANGE","feature request","bug","documentation","maintenance","dependencies:update","dependencies","other"]

Generated by 🚫 dangerJS

@codecov
Copy link

codecov bot commented Sep 5, 2018

Codecov Report

Merging #4121 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4121      +/-   ##
=========================================
+ Coverage   40.59%   40.6%   +0.01%     
=========================================
  Files         483     483              
  Lines        5747    5748       +1     
  Branches      770     770              
=========================================
+ Hits         2333    2334       +1     
  Misses       3042    3042              
  Partials      372     372
Impacted Files Coverage Δ
lib/core/src/server/mergeConfigs.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6de989...d5efe6c. Read the comment docs.

@Hypnosphi Hypnosphi merged commit 87572f7 into storybookjs:master Sep 8, 2018
@shilman shilman changed the title Merge optimisation configs Merge webpack optimisation configs Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants