Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[react]: allow v1 or v2 in airbnb-js-shims #4190

Merged
merged 1 commit into from
Sep 17, 2018
Merged

[react]: allow v1 or v2 in airbnb-js-shims #4190

merged 1 commit into from
Sep 17, 2018

Conversation

ljharb
Copy link
Contributor

@ljharb ljharb commented Sep 17, 2018

Resolves #3955; related to #4189.

@ljharb ljharb mentioned this pull request Sep 17, 2018
Closed
@shilman shilman self-assigned this Sep 17, 2018
shilman
shilman approved these changes Sep 17, 2018
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will fix the failing CLI tests after the merge

@shilman shilman merged commit 7036d46 into storybookjs:release/3.4 Sep 17, 2018
@ljharb ljharb deleted the patch-2 branch September 17, 2018 21:54
@ljharb
Copy link
Contributor Author

ljharb commented Sep 17, 2018

Thank you!

This was referenced Oct 1, 2018
Closed
Open
Closed
Closed
Open
Closed
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

Assignees

@shilman shilman

Labels
dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ljharb @shilman