Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade deps dealing with license issues #4228

Merged
merged 1 commit into from
Sep 25, 2018
Merged

Upgrade deps dealing with license issues #4228

merged 1 commit into from
Sep 25, 2018

Conversation

pksunkara
Copy link
Member

@pksunkara pksunkara commented Sep 25, 2018

This PR upgrades deps to recent releases of many packages which fixed license issues related to Lerna. Really important for some companies to make use of storybook easily. Things to do before this is merged:

  • Wait for webpack next release, upgrade here
  • Move to @storybook/react-treebeard after merging @ndelangen's changes

@storybook-safe-bot
Copy link
Contributor

Fails
🚫

PR is marked with "do not merge" label.

Generated by 🚫 dangerJS

@pksunkara pksunkara requested a review from naipath as a code owner September 25, 2018 13:28
@codecov
Copy link

codecov bot commented Sep 25, 2018

Codecov Report

Merging #4228 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4228   +/-   ##
=======================================
  Coverage   40.79%   40.79%           
=======================================
  Files         493      493           
  Lines        5851     5851           
  Branches      782      782           
=======================================
  Hits         2387     2387           
  Misses       3088     3088           
  Partials      376      376

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5728bda...8c34f16. Read the comment docs.

@shilman shilman merged commit c8610b0 into master Sep 25, 2018
@shilman shilman deleted the pksunkara/deps branch September 25, 2018 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants