fix #2384: support string-only component for vue #4285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igor-dv
requested changes
Oct 8, 2018
app/vue/src/client/preview/render.js
Outdated
| @@ -20,6 +20,10 @@ export default function render({ | |||
| Vue.config.errorHandler = showException; | |||
|
|
|||
| const component = story(); | |||
|
|
|||
| if (typeof component === 'string') { | |||
| component = { template: component }; | |||
There was a problem hiding this comment.
component is a const, you can't reassign it, can you please fix it ?
I think we need an example story as well.
Codecov Report
@@ Coverage Diff @@
## master #4285 +/- ##
==========================================
- Coverage 40.2% 40.19% -0.02%
==========================================
Files 510 510
Lines 5944 5946 +2
Branches 794 795 +1
==========================================
Hits 2390 2390
- Misses 3169 3170 +1
- Partials 385 386 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #2384
What I did
Add support for string only component