Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4269 iPhone viewport dimensions #4293

Conversation

J-Kallunki
Copy link
Contributor

Issue: #4269

Fixed config of iPhone viewport dimensions
Reference config file.

@J-Kallunki J-Kallunki requested a review from saponifi3d as a code owner October 5, 2018 03:22
@storybook-safe-bot
Copy link
Contributor

Fails
🚫

PR is not labeled with one of: ["cleanup","BREAKING CHANGE","feature request","bug","documentation","maintenance","dependencies:update","dependencies","other"]

Generated by 🚫 dangerJS

@gabrielcsapo
Copy link
Contributor

@J-Kallunki thank you for the submission! Would you be able to resolve the unit test failures?

@igor-dv igor-dv added the bug label Oct 8, 2018
@codecov
Copy link

codecov bot commented Oct 10, 2018

Codecov Report

Merging #4293 into master will increase coverage by 48.42%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #4293       +/-   ##
===========================================
+ Coverage    40.2%   88.63%   +48.42%     
===========================================
  Files         510        6      -504     
  Lines        5944       44     -5900     
  Branches      794        2      -792     
===========================================
- Hits         2390       39     -2351     
+ Misses       3169        4     -3165     
+ Partials      385        1      -384
Impacted Files Coverage Δ
...toryshots-core/src/frameworks/svelte/renderTree.js
addons/backgrounds/mithril.js
addons/knobs/src/components/types/Select.js
...yshots/storyshots-core/src/frameworks/rn/loader.js
addons/storysource/src/loader/parsers/index.js
lib/ui/src/modules/ui/configs/handle_routing.js
...ents/stories_panel/stories_tree/tree_decorators.js
lib/cli/lib/initiate.js
...-native/src/preview/components/OnDeviceUI/style.js
lib/core/src/server/config.js
... and 493 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db9616b...6b9c5c5. Read the comment docs.

@J-Kallunki
Copy link
Contributor Author

@J-Kallunki thank you for the submission! Would you be able to resolve the unit test failures?

Yeah I fixed Viewport test but circeci: cli:
"could not find a copy of webpack to link in /tmp/storybook/node_modules/react-static-next-fixture/node_modules/uglifyjs-webpack-plugin/node_modules"

@igor-dv
Copy link
Member

igor-dv commented Oct 10, 2018

This is not related to your changes.

@gabrielcsapo
Copy link
Contributor

🙌 awesome!

@gabrielcsapo gabrielcsapo merged commit 35c45ab into storybookjs:master Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants