Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated attempt to load default addons #4308

Merged
merged 6 commits into from
Oct 13, 2018

Conversation

kevincolten
Copy link
Contributor

Issue: #4307

Default addon functionality removed in
ab9cfc9#diff-7389ec091319dd03cb9f3c3d9472182d

What I did

Remove deprecated attempt to load default addons

@codecov
Copy link

codecov bot commented Oct 7, 2018

Codecov Report

Merging #4308 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4308      +/-   ##
==========================================
+ Coverage    36.2%   36.21%   +0.01%     
==========================================
  Files         556      556              
  Lines        6560     6558       -2     
  Branches      848      848              
==========================================
  Hits         2375     2375              
+ Misses       3754     3752       -2     
  Partials      431      431
Impacted Files Coverage Δ
app/react-native/src/server/config.js 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be43505...10ce2f7. Read the comment docs.

@storybook-safe-bot
Copy link
Contributor

Fails
🚫

PR is not labeled with one of: ["cleanup","BREAKING CHANGE","feature request","bug","documentation","maintenance","dependencies:update","dependencies","other"]

Generated by 🚫 dangerJS

@igor-dv
Copy link
Member

igor-dv commented Oct 8, 2018

Can you please merge from master? It should fix the CI

@igor-dv igor-dv added api: addons react-native cleanup Minor cleanup style change that won't show up in release changelog labels Oct 8, 2018
@Hypnosphi Hypnosphi merged commit 7312406 into storybookjs:master Oct 13, 2018
@kevincolten kevincolten deleted the patch-1 branch October 13, 2018 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: addons cleanup Minor cleanup style change that won't show up in release changelog react-native
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants