Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose webpackFinal extension #4431

Merged
merged 1 commit into from
Oct 16, 2018
Merged

Conversation

igor-dv
Copy link
Member

@igor-dv igor-dv commented Oct 15, 2018

Issue:
angular-cli preset should filter out all the styling rules in order to integrate its rules instead.
Currently, angular-cli preset is kicked-in in the middle of the presets chain because it's a framework preset.

The last preset in the chain adds default rules or execute the custom webpack config. We need the ability for other presets to clean the webpack config after all the manipulations.

image

Related #4296

What I did

I've added the webpackFinal step.

@codecov
Copy link

codecov bot commented Oct 15, 2018

Codecov Report

Merging #4431 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4431      +/-   ##
==========================================
- Coverage   35.98%   35.97%   -0.02%     
==========================================
  Files         555      555              
  Lines        6650     6652       +2     
  Branches      871      871              
==========================================
  Hits         2393     2393              
- Misses       3810     3812       +2     
  Partials      447      447
Impacted Files Coverage Δ
...angular/src/server/framework-preset-angular-cli.js 0% <ø> (ø) ⬆️
lib/core/src/server/config.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8961222...47de36f. Read the comment docs.

@igor-dv igor-dv added this to the v4.0.0 milestone Oct 15, 2018
@igor-dv
Copy link
Member Author

igor-dv commented Oct 15, 2018

Looks like it should also fix the initial issue from #4230

Copy link
Member

@kroeder kroeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, thanks for clarifying presets

@igor-dv igor-dv merged commit e638fe4 into master Oct 16, 2018
@igor-dv igor-dv deleted the core/export-wepack-final-for-presets branch October 16, 2018 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants