Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document React 16.3 dependency #4458

Merged
merged 1 commit into from
Oct 17, 2018
Merged

Document React 16.3 dependency #4458

merged 1 commit into from
Oct 17, 2018

Conversation

shilman
Copy link
Member

@shilman shilman commented Oct 17, 2018

Issue: N/A

What I did

  • Added migration docs
  • Added a peer dep since Emotion doesn't seem to catch this

NOTE: I'm going to take a full pass at MIGRATION.md soon, just gathering up all the bullet points first.

@tmeasday
Copy link
Member

Can we put the exact error message in here? Could help people googling

@tmeasday
Copy link
Member

core.browser.esm.js:15 Uncaught TypeError: Object(...) is not a function
    at Module../node_modules/@emotion/core/dist/core.browser.esm.js (core.browser.esm.js:15)
    at __webpack_require__ (bootstrap:724)
    at fn (bootstrap:101)
    at Module../node_modules/@emotion/styled-base/dist/styled-base.browser.esm.js (styled-base.browser.esm.js:1)
    at __webpack_require__ (bootstrap:724)
    at fn (bootstrap:101)
    at Module../node_modules/@emotion/styled/dist/styled.esm.js (styled.esm.js:1)
    at __webpack_require__ (bootstrap:724)
    at fn (bootstrap:101)
    at Object../node_modules/@storybook/components/dist/navigation/MenuLink.js (MenuLink.js:12)

@codecov
Copy link

codecov bot commented Oct 17, 2018

Codecov Report

Merging #4458 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4458   +/-   ##
=======================================
  Coverage   35.96%   35.96%           
=======================================
  Files         555      555           
  Lines        6653     6653           
  Branches      871      871           
=======================================
  Hits         2393     2393           
  Misses       3813     3813           
  Partials      447      447

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f127f0...0c02f72. Read the comment docs.

@ndelangen ndelangen merged commit 7770bf5 into master Oct 17, 2018
@ndelangen ndelangen deleted the shilman/react-16.3-docs branch October 17, 2018 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants