Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mini-css-extract-plugin to app/react dependencies #4534

Merged

Conversation

chadfawcett
Copy link
Member

Issue: Related to #4405 and failing tests of #4524

What I did

Added mini-css-extract-plugin to app/react dependencies

How to test

Automated tests should cover this

@codecov
Copy link

codecov bot commented Oct 23, 2018

Codecov Report

Merging #4534 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4534   +/-   ##
=======================================
  Coverage   35.58%   35.58%           
=======================================
  Files         557      557           
  Lines        6730     6730           
  Branches      883      883           
=======================================
  Hits         2395     2395           
  Misses       3876     3876           
  Partials      459      459
Impacted Files Coverage Δ
app/react/src/server/cra_config.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 182bccc...ab85679. Read the comment docs.

@Hypnosphi Hypnosphi merged commit 5b2d316 into storybookjs:master Oct 23, 2018
@chadfawcett chadfawcett deleted the add-cra-mini-css-extract-plugin branch October 23, 2018 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants