Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added typescript definition to addon notes #989

Merged
merged 3 commits into from
May 10, 2017

Conversation

fabien0102
Copy link
Contributor

@fabien0102 fabien0102 commented May 3, 2017

Issue: #953

What I did

Add typescript definition to add-notes addons

How to test

I test locally on my current project, you can have a look here

Note

The package.json seams to be with CRLF before, it explain the wtf diff (I've only added types and devDepencencies/@types/react)

@codecov
Copy link

codecov bot commented May 3, 2017

Codecov Report

Merging #989 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #989   +/-   ##
=======================================
  Coverage   12.61%   12.61%           
=======================================
  Files         192      192           
  Lines        4424     4424           
  Branches      707      707           
=======================================
  Hits          558      558           
  Misses       3241     3241           
  Partials      625      625

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7910ae6...666b7b2. Read the comment docs.

@ndelangen
Copy link
Member

@fabien0102 Thank you for this PR! It looks good, I'll merge it.

@ndelangen ndelangen merged commit 56d779b into storybookjs:master May 10, 2017
@shilman shilman added the misc label May 27, 2017
@ndelangen ndelangen changed the title Add typescript definition to addon-notes Add typescript definition to addon notes May 27, 2017
@shilman shilman changed the title Add typescript definition to addon notes Added typescript definition to addon notes May 28, 2017
Copy link

nx-cloud bot commented May 16, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 666b7b2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants