Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Stable token factory #269

Merged
merged 8 commits into from
Nov 14, 2023
Merged

feat: add Stable token factory #269

merged 8 commits into from
Nov 14, 2023

Conversation

johnletey
Copy link
Member

No description provided.

@johnletey johnletey requested review from agouin and boojamya November 13, 2023 14:22
@johnletey johnletey self-assigned this Nov 13, 2023
Copy link
Member

@boojamya boojamya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey John, it's lookin good!

Any reason you got rid of all the previous app/upgrades folders? Or just a cleanup?

ALSO,
We will want to add the new stabletokenfactory to the OnRecPacket in the blockibc middleware.

@johnletey
Copy link
Member Author

Thanks for the review @boojamya 🔥

Any reason you got rid of all the previous app/upgrades folders? Or just a cleanup?

This is strictly a cleanup.

We will want to add the new stabletokenfactory to the OnRecPacket in the blockibc middleware.

Very nice catch! Made this change in ab3b6ff, feel free to check it out!

I also have one more change coming, which allows the x/tariff module to have multiple different fee denoms (right now it only supports one, namely uusdc).

@johnletey johnletey marked this pull request as ready for review November 14, 2023 11:17
@johnletey johnletey requested a review from boojamya November 14, 2023 11:17
Copy link
Member

@boojamya boojamya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Looks good!

@johnletey johnletey merged commit a2bfe39 into main Nov 14, 2023
24 checks passed
@johnletey johnletey deleted the john/stable-token-factory branch November 14, 2023 20:56
@johnletey
Copy link
Member Author

@Mergifyio backport release/v4.1.x

Copy link

mergify bot commented Nov 14, 2023

backport release/v4.1.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 14, 2023
johnletey added a commit that referenced this pull request Nov 14, 2023
Co-authored-by: John Letey <john@nobleassets.xyz>
johnletey added a commit that referenced this pull request Nov 23, 2023
johnletey added a commit that referenced this pull request Nov 23, 2023
mergify bot pushed a commit that referenced this pull request Nov 23, 2023
(cherry picked from commit 8b0eb68)

# Conflicts:
#	.changelog/v4.1.0-rc.0/features/269-stable-token-factory.md
#	.changelog/v4.1.0-rc.0/improvements/269-multiple-denom-fees.md
#	.github/mergify.yml
#	app/ante.go
#	app/app.go
#	app/upgrades/v4.1.0/store.go
#	interchaintest/genesis_test.go
#	interchaintest/go.mod
#	proto/stable/tokenfactory/v1/blacklisted.proto
#	proto/stable/tokenfactory/v1/blacklister.proto
#	proto/stable/tokenfactory/v1/genesis.proto
#	proto/stable/tokenfactory/v1/master_minter.proto
#	proto/stable/tokenfactory/v1/minter_controller.proto
#	proto/stable/tokenfactory/v1/minters.proto
#	proto/stable/tokenfactory/v1/minting_denom.proto
#	proto/stable/tokenfactory/v1/owner.proto
#	proto/stable/tokenfactory/v1/params.proto
#	proto/stable/tokenfactory/v1/paused.proto
#	proto/stable/tokenfactory/v1/pauser.proto
#	proto/stable/tokenfactory/v1/query.proto
#	proto/stable/tokenfactory/v1/tx.proto
#	testutil/keeper/stabletokenfactory.go
#	x/blockibc/blockibc.go
#	x/stabletokenfactory/client/cli/query.go
#	x/stabletokenfactory/client/cli/query_blacklisted.go
#	x/stabletokenfactory/client/cli/query_blacklister.go
#	x/stabletokenfactory/client/cli/query_master_minter.go
#	x/stabletokenfactory/client/cli/query_minter_controller.go
#	x/stabletokenfactory/client/cli/query_minters.go
#	x/stabletokenfactory/client/cli/query_minting_denom.go
#	x/stabletokenfactory/client/cli/query_owner.go
#	x/stabletokenfactory/client/cli/query_params.go
#	x/stabletokenfactory/client/cli/query_paused.go
#	x/stabletokenfactory/client/cli/query_pauser.go
#	x/stabletokenfactory/client/cli/tx.go
#	x/stabletokenfactory/client/cli/tx_accept_owner.go
#	x/stabletokenfactory/client/cli/tx_blacklist.go
#	x/stabletokenfactory/client/cli/tx_burn.go
#	x/stabletokenfactory/client/cli/tx_configure_minter.go
#	x/stabletokenfactory/client/cli/tx_configure_minter_controller.go
#	x/stabletokenfactory/client/cli/tx_mint.go
#	x/stabletokenfactory/client/cli/tx_pause.go
#	x/stabletokenfactory/client/cli/tx_remove_minter.go
#	x/stabletokenfactory/client/cli/tx_remove_minter_controller.go
#	x/stabletokenfactory/client/cli/tx_unblacklist.go
#	x/stabletokenfactory/client/cli/tx_unpause.go
#	x/stabletokenfactory/client/cli/tx_update_blacklister.go
#	x/stabletokenfactory/client/cli/tx_update_master_minter.go
#	x/stabletokenfactory/client/cli/tx_update_owner.go
#	x/stabletokenfactory/client/cli/tx_update_pauser.go
#	x/stabletokenfactory/genesis.go
#	x/stabletokenfactory/genesis_test.go
#	x/stabletokenfactory/keeper/blacklisted.go
#	x/stabletokenfactory/keeper/blacklisted_test.go
#	x/stabletokenfactory/keeper/blacklister.go
#	x/stabletokenfactory/keeper/blacklister_test.go
#	x/stabletokenfactory/keeper/grpc_query.go
#	x/stabletokenfactory/keeper/grpc_query_blacklisted.go
#	x/stabletokenfactory/keeper/grpc_query_blacklisted_test.go
#	x/stabletokenfactory/keeper/grpc_query_blacklister.go
#	x/stabletokenfactory/keeper/grpc_query_blacklister_test.go
#	x/stabletokenfactory/keeper/grpc_query_master_minter.go
#	x/stabletokenfactory/keeper/grpc_query_master_minter_test.go
#	x/stabletokenfactory/keeper/grpc_query_minter_controller.go
#	x/stabletokenfactory/keeper/grpc_query_minter_controller_test.go
#	x/stabletokenfactory/keeper/grpc_query_minters.go
#	x/stabletokenfactory/keeper/grpc_query_minters_test.go
#	x/stabletokenfactory/keeper/grpc_query_minting_denom.go
#	x/stabletokenfactory/keeper/grpc_query_minting_denom_test.go
#	x/stabletokenfactory/keeper/grpc_query_owner.go
#	x/stabletokenfactory/keeper/grpc_query_owner_test.go
#	x/stabletokenfactory/keeper/grpc_query_params.go
#	x/stabletokenfactory/keeper/grpc_query_params_test.go
#	x/stabletokenfactory/keeper/grpc_query_paused.go
#	x/stabletokenfactory/keeper/grpc_query_paused_test.go
#	x/stabletokenfactory/keeper/grpc_query_pauser.go
#	x/stabletokenfactory/keeper/grpc_query_pauser_test.go
#	x/stabletokenfactory/keeper/keeper.go
#	x/stabletokenfactory/keeper/master_minter.go
#	x/stabletokenfactory/keeper/master_minter_test.go
#	x/stabletokenfactory/keeper/minter_controller.go
#	x/stabletokenfactory/keeper/minter_controller_test.go
#	x/stabletokenfactory/keeper/minters.go
#	x/stabletokenfactory/keeper/minters_test.go
#	x/stabletokenfactory/keeper/minting_denom.go
#	x/stabletokenfactory/keeper/minting_denom_test.go
#	x/stabletokenfactory/keeper/msg_server.go
#	x/stabletokenfactory/keeper/msg_server_accept_owner.go
#	x/stabletokenfactory/keeper/msg_server_blacklist.go
#	x/stabletokenfactory/keeper/msg_server_burn.go
#	x/stabletokenfactory/keeper/msg_server_configure_minter.go
#	x/stabletokenfactory/keeper/msg_server_configure_minter_controller.go
#	x/stabletokenfactory/keeper/msg_server_mint.go
#	x/stabletokenfactory/keeper/msg_server_pause.go
#	x/stabletokenfactory/keeper/msg_server_remove_minter.go
#	x/stabletokenfactory/keeper/msg_server_remove_minter_controller.go
#	x/stabletokenfactory/keeper/msg_server_unblacklist.go
#	x/stabletokenfactory/keeper/msg_server_unpause.go
#	x/stabletokenfactory/keeper/msg_server_update_blacklister.go
#	x/stabletokenfactory/keeper/msg_server_update_master_minter.go
#	x/stabletokenfactory/keeper/msg_server_update_owner.go
#	x/stabletokenfactory/keeper/msg_server_update_pauser.go
#	x/stabletokenfactory/keeper/owner.go
#	x/stabletokenfactory/keeper/owner_test.go
#	x/stabletokenfactory/keeper/params.go
#	x/stabletokenfactory/keeper/params_test.go
#	x/stabletokenfactory/keeper/paused.go
#	x/stabletokenfactory/keeper/paused_test.go
#	x/stabletokenfactory/keeper/pauser.go
#	x/stabletokenfactory/keeper/pauser_test.go
#	x/stabletokenfactory/module.go
#	x/stabletokenfactory/module_simulation.go
#	x/stabletokenfactory/simulation/blacklist.go
#	x/stabletokenfactory/simulation/burn.go
#	x/stabletokenfactory/simulation/configure_minter.go
#	x/stabletokenfactory/simulation/configure_minter_controller.go
#	x/stabletokenfactory/simulation/mint.go
#	x/stabletokenfactory/simulation/pause.go
#	x/stabletokenfactory/simulation/remove_minter.go
#	x/stabletokenfactory/simulation/remove_minter_controller.go
#	x/stabletokenfactory/simulation/unblacklist.go
#	x/stabletokenfactory/simulation/unpause.go
#	x/stabletokenfactory/simulation/update_blacklister.go
#	x/stabletokenfactory/simulation/update_master_minter.go
#	x/stabletokenfactory/simulation/update_owner.go
#	x/stabletokenfactory/simulation/update_pauser.go
#	x/stabletokenfactory/types/blacklisted.pb.go
#	x/stabletokenfactory/types/blacklister.pb.go
#	x/stabletokenfactory/types/genesis.pb.go
#	x/stabletokenfactory/types/genesis_test.go
#	x/stabletokenfactory/types/master_minter.pb.go
#	x/stabletokenfactory/types/message_blacklist_test.go
#	x/stabletokenfactory/types/message_burn_test.go
#	x/stabletokenfactory/types/message_configure_minter_controller_test.go
#	x/stabletokenfactory/types/message_configure_minter_test.go
#	x/stabletokenfactory/types/message_mint_test.go
#	x/stabletokenfactory/types/message_pause_test.go
#	x/stabletokenfactory/types/message_remove_minter_controller_test.go
#	x/stabletokenfactory/types/message_remove_minter_test.go
#	x/stabletokenfactory/types/message_unblacklist_test.go
#	x/stabletokenfactory/types/message_unpause_test.go
#	x/stabletokenfactory/types/message_update_blacklister_test.go
#	x/stabletokenfactory/types/message_update_master_minter_test.go
#	x/stabletokenfactory/types/message_update_owner_test.go
#	x/stabletokenfactory/types/message_update_pauser_test.go
#	x/stabletokenfactory/types/minter_controller.pb.go
#	x/stabletokenfactory/types/minters.pb.go
#	x/stabletokenfactory/types/minting_denom.pb.go
#	x/stabletokenfactory/types/owner.pb.go
#	x/stabletokenfactory/types/params.pb.go
#	x/stabletokenfactory/types/paused.pb.go
#	x/stabletokenfactory/types/pauser.pb.go
#	x/stabletokenfactory/types/query.pb.go
#	x/stabletokenfactory/types/tx.pb.go
#	x/tariff/types/params.pb.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants