Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to style wrapper divs #35

Open
andriadze opened this issue Jul 31, 2019 · 3 comments
Open

Ability to style wrapper divs #35

andriadze opened this issue Jul 31, 2019 · 3 comments

Comments

@andriadze
Copy link

I think library adds two wrapper divs. Both of them have inline style and they have no classname or id given to them.

@scottyantipa
Copy link
Contributor

What is the use case that you aren't able to accomplish? The wrapper div will size itself to its parent. So the parent div that you provid, wrapping this component, can be sized/styled however you like. If this isn't enough though, then I think its fine to add props for inline styles to map-interaction.

@andriadze
Copy link
Author

Well use case is quite simple, I have a component that takes up height of its direct parent. So all I needed to do was give the wrapper view a height property in css and that was that.

I mean just giving classNames to the divs won't hurt anything.

I solved it by just copying content from MapInteractionsCss and updating that one css line.

@ametis70
Copy link

The ability to modify the wrapper style through classes or style props is useful when the container has its display set to flex, for instance (I ran into this right now, but maybe there are some other examples). In that case, the children of MapInteractionsCSS won't be affected affected by the wrapper's width or height

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants