Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect error message when unable to create FS #1141

Closed
tasleson opened this issue Aug 31, 2018 · 2 comments
Closed

Incorrect error message when unable to create FS #1141

tasleson opened this issue Aug 31, 2018 · 2 comments
Milestone

Comments

@tasleson
Copy link
Contributor

If you exhaust the pool when trying to create a FS you get:

# bin/stratis filesystem create raided fs3
Execution failure caused by:
INTERNAL ERROR: Command failed: cmd: "/usr/sbin/mkfs.xfs" "-f" "-q" "/dev/dm-17" "-m" "uuid=cc37f37d-3aa5-4d6d-8aeb-4f79af486eec", stdout:  stderr: mkfs.xfs: libxfs_device_zero write failed: No space left on device

Listing this as an INTERNAL ERROR seems incorrect considering that we ran out of space.

@mulkieran
Copy link
Member

All errors in StratisError::Error are translated to an INTERNAL_ERROR before being place on the D-Bus. Most likely this is wrong in most instances where StratisError::Error occurs. All errors in StratisError::Uuid, StratisError::Utf8, StratisError::Serde, StratisError::DM, StratisError::Dbus, and StratisError::Udev are also being mapped to INTERNAL_ERROR. Ditto.

AFAIAC, our error handling in the D-Bus layer needs a complete overhaul.

@agrover
Copy link
Contributor

agrover commented Sep 18, 2018

duplicate of #1181 and #534, closing.

@agrover agrover closed this as completed Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants