Add reset util to useList #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Belco90
approved these changes
Oct 7, 2019
streamich
pushed a commit
that referenced
this pull request
Oct 7, 2019
# [12.3.0](v12.2.3...v12.3.0) (2019-10-07) ### Features * reset util callback for useList ([#654](#654)) ([9ea3548](9ea3548))
|
🎉 This PR is included in version 12.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useMaphas aresetcallback that resets the state to its initial value which I was missing inuseListso I added it here. I also added tests and updated the docs and story.I also added memoization of the callback utils and aded tests for this.
Last but not least I was thinking about removing
clearbecause you mostly need to be able to clear the array when you're starting with an empty array in the first place. Theresetcallback proposed here results in the same behaviour as it resets to the initial (default) value[]. I haven't implemented it as I wanted to know what others think