Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: useUpdateEffect test returning false positive #865

Merged
merged 1 commit into from
Jan 8, 2020
Merged

fix: useUpdateEffect test returning false positive #865

merged 1 commit into from
Jan 8, 2020

Conversation

adesurirey
Copy link
Contributor

@adesurirey adesurirey commented Jan 7, 2020 •
edited
Loading

Description

The test of my previous PR #864 is wrongly successful, I was testing that the effect was called, not the cleanup! This PR fixes it by testing that the cleanup effect was called on unmount, not the effect.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as before)

Checklist

  • Read the Contributing Guide
  • Perform a code self-review
  • Comment the code, particularly in hard-to-understand areas
  • Add documentation
  • Add hook's story at Storybook
  • Cover changes with tests
  • Ensure the test suite passes (yarn test)
  • Provide 100% tests coverage
  • Make sure code lints (yarn lint). Fix it with yarn lint:fix in case of failure.
  • Make sure types are fine (yarn lint:types).

@adesurirey adesurirey changed the title fix: useUpdateEffect returns optional cleanup function fix: useUpdateEffect test returns false positive Jan 7, 2020
@adesurirey adesurirey changed the title fix: useUpdateEffect test returns false positive fix: useUpdateEffect test returning false positive Jan 8, 2020
streamich
streamich approved these changes Jan 8, 2020
View reviewed changes
Copy link
Owner

@streamich streamich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@streamich streamich merged commit 1946006 into streamich:master Jan 8, 2020
streamich pushed a commit that referenced this pull request Jan 8, 2020
@semantic-release-bot
chore(release): 13.14.3 [skip ci]
9eb571c 
## [13.14.3](v13.14.2...v13.14.3) (2020-01-08)

### Bug Fixes

* useUpdateEffect cleanup test returns false positive ([9b31c42](9b31c42))
* useUpdateEffect test returning false positive ([#865](#865)) ([1946006](1946006))
@streamich
Copy link
Owner

🎉 This PR is included in version 13.14.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@streamich streamich streamich approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adesurirey @streamich