Add hook to successful connect response #21
Conversation
https.go
Outdated
| @@ -177,7 +178,18 @@ func (proxy *ProxyHttpServer) handleHttps(w http.ResponseWriter, r *http.Request | |||
|
|
|||
| case ConnectHijack: | |||
There was a problem hiding this comment.
what's the difference between ConnectAccept and ConnectHijack? it doesn't seem like ConnectHijack actually makes a request to the backend so I'm not sure if ConnectRespHandler can do anything interesting. or are there fields on the *ProxyCtx set elsewhere?
There was a problem hiding this comment.
No, you're totally right and it belongs in AcceptConnect! I got myself confused because Hijack() is also the method you call to override the HTTP protocol on the http client and I didn't realize it was overloaded here
| return nil, nil | ||
| } | ||
| resp := &http.Response{Status: "200 OK", StatusCode: 200, Proto: "HTTP/1.0", Header: http.Header{}} | ||
| err := ctx.proxy.ConnectRespHandler(ctx, resp) |
There was a problem hiding this comment.
if we want the response to contain any info from the connection to the backend server, do we also need to pass the net.Conn (targetSiteCon) as an argument or is this available on the ctx?
There was a problem hiding this comment.
Should be available on the context! e.g. to get destination IP it should be possible to get the smokescreen context from the goproxy context UserData like this, and then get decision.resolvedAddr from that.
Provides a hook to allow for custom modifications to the 200 CONNECT response, such as adding a header.
I've opted to simply add a function to the proxy config rather than try to fit this functionality into the actions.go OnRequest/OnResponse framework; since CONNECT requests already have special-case fields such as ConnectCopyHandler and ConnectDialContext, this seems reasonable and also avoids additional complexity or modifications to existing logic.