cmd: make dsn a non-mandatory flag to allow use of Postgres environment variables #54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
psql
and programs usinglibpq
allows users to use the environment variablesPGHOST
and friends to specify the connection information. This PR implements the same behavior forpg-schema-diff
by making the DSN flag non-mandatory.Motivation
pg-schema-diff
"just work" in our workflow.Implementation
pg-schema-diff's
(connFlags).parseConnConfig()
callspgx.ParseConfig()
, which callspgconn.ParseConfigWithOptions()
pgconn.ParseConfigWithOptions
already reads the Postgres environment variables.Testing